Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-builtinreducers-Sum transition from md to rst #268

Merged
merged 6 commits into from
Jan 25, 2023
Merged

#120: API-core-builtinreducers-Sum transition from md to rst #268

merged 6 commits into from
Jan 25, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jan 19, 2023 •
edited
Loading

THIS PR:

  • API/core/builtinreducers/Sum transition from .md to .rst
before (.md) after (.rst) after 2 (.rst) [current code]
before1 after1
before2 after2 image
before3 after3

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 19, 2023
Closed
ajpowelsnl
ajpowelsnl reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- only a small suggestion on word choice if you wanted to do it.

docs/source/API/core/builtinreducers/Sum.rst Outdated Show resolved Hide resolved
ajpowelsnl
ajpowelsnl reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have an opinion about my word choice suggestion (line 91)?

fnrizzi
fnrizzi requested changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment on indentation: https://github.com/kokkos/kokkos-core-wiki/pull/271/files#r1084323761

nmm0
nmm0 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fnrizzi fnrizzi merged commit c04bd46 into kokkos:main Jan 25, 2023
@antoinemeyer5 antoinemeyer5 deleted the 120-API-core-builtinreducers-Sum branch June 14, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

@nmm0 nmm0 nmm0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoinemeyer5 @nmm0 @fnrizzi @ajpowelsnl